This repository has been archived by the owner on Feb 2, 2019. It is now read-only.
Bug 1396517 - Make Fennec graph 2 not reference graph 1 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaiTabara
reviewed
Sep 4, 2017
releasetasks/__init__.py
Outdated
| graph_2_id = make_fennec_graph_2_not_reference_graph_1(tasks, branch, product, stableSlugId) \ | ||
| if product == 'fennec' else None | ||
|
|
||
| return taskGroupId, sort_tasks(tasks), graph_2_id |
There was a problem hiding this comment.
Aren't you changing the structure of returning variables here?
MihaiTabara
reviewed
Sep 4, 2017
| @@ -5,6 +5,7 @@ | |||
| task: | |||
| provisionerId: aws-provisioner-v1 | |||
| workerType: gecko-decision | |||
| schedulerId: gecko-level-3 | |||
There was a problem hiding this comment.
This failure occurred without it: https://tools.taskcluster.net/groups/ffYqzngiQUiOFEdlZ_8bVQ/tasks/ffYqzngiQUiOFEdlZ_8bVQ/details
Basically, TC checks that the same scheduler schedules all the task of a taskgroup, which is not really true here :/
There was a problem hiding this comment.
Ah, right. Thanks for explanations!
MihaiTabara
approved these changes
Sep 4, 2017
There was a problem hiding this comment.
This change is intended to be temporary; a better fix will be pushed later on this week to https://github.com/mozilla-releng/scriptworker
| @@ -5,6 +5,7 @@ | |||
| task: | |||
| provisionerId: aws-provisioner-v1 | |||
| workerType: gecko-decision | |||
| schedulerId: gecko-level-3 | |||
There was a problem hiding this comment.
Ah, right. Thanks for explanations!
JohanLorenzo
added a commit
that referenced
this pull request
Sep 7, 2017
This reverts commit 233a35b.
JohanLorenzo
added a commit
that referenced
this pull request
Sep 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.